案件 • Board Game Arena

所有案件

Sunrise Sunset 的案件

#141680: "incorrect score display"

fixed: 錯誤已修復

這是關於哪方面的案件？

Sunrise Sunset #573531232

發生什麼事? 請從下方選擇

顯示異常：部分遊戲資訊顯示錯誤（未造成嚴重後果）

發生什麼事? 請從下方選擇

顯示異常：部分遊戲資訊顯示錯誤（未造成嚴重後果）

請檢查是否已有同課題案件

若肯定，請「投票」給這樁案件。最高票的案件將「優先」處理！

#	Status	Votes	Game	Type	Title	Last update

細節描述

案件沿革

2024年Oct11日 23:15 • Biolog Psihopat • 開發者尚未重現這項錯誤:

imgur.com/a/r5gUSEU

2024年Oct12日 02:21 • Biolog Psihopat • 開發者尚未重現這項錯誤:

PS. that not at the end of the game, so this is a slightly different situation compared to my next note (that image from 2nd round, when game ends at 5th round)

2024年Oct20日 12:35 • giantroach • 開發者已確認這項錯誤:

- Isis power should be 4 instead of 6, and Apofis power should be 6 instead of 4.
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).

Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)

2024年Oct26日 15:32 • giantroach • 開發者已確認這項錯誤:

I reproduced this bug myself.
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.

This needs further investigation.

2024年Oct26日 16:22 • giantroach • 開發者已確認這項錯誤:

One possible root cause is found:

github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092

1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304

If a player is playing in other than English language (in my case Japanese), this logic won't work.

Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841

So I suspect this is not yet everything.

2024年Nov6日 20:00 • giantroach • 開發者已確認這項錯誤:

Not everything, but nearly all the doubt is solved (Fixing needs an extra work.)

1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!

1. and 2. should be fixed. Do not restore the score data unless it is endRound state.

2024年Nov8日 16:49 • giantroach • 錯誤已修復:

This bug is fixed.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.

為本案件添加內容

任何可能重現這項錯誤或了解你的建議之相關資訊，都請在此填寫:

其他同樣狀況的桌號／步數
按 F5 是否解決了這個問題？
問題是否發生了好幾次？每次都發生？時好時壞？
建議將此錯誤的螢幕截圖上傳到 Imgur.com 並轉貼連結。

取消更新案情

#141680: "incorrect score display"

這是關於哪方面的案件？

發生什麼事? 請從下方選擇

發生什麼事? 請從下方選擇

請檢查是否已有同課題案件

細節描述

案件沿革

為本案件添加內容

更改案件狀態為：

說明

貢獻

導覽

追蹤我們